Apache log4j logo Apache logging services logo

Checkstyle Results

The following document contains the results of Checkstyle 6.11.2 with /Users/rgoers/projects/apache/logging/log4j/log4j-audit-1.0.1/log4j-catalog/log4j-catalog-editor/../../checkstyle.xml ruleset. rss feed

Summary

Files  Info  Warnings  Errors
17 0 0 198

Details

application.properties

Severity Category Rule Message Line
 Error misc NewlineAtEndOfFile File does not end with a newline.

org/apache/logging/log4j/catalog/AuditCatalogEditor.java

Severity Category Rule Message Line
 Error javadoc JavadocPackage Missing package-info.java file.
 Error javadoc JavadocMethod Expected an @return tag. 45

org/apache/logging/log4j/catalog/config/ConfigurationService.java

Severity Category Rule Message Line
 Error javadoc JavadocType Missing a Javadoc comment. 22

org/apache/logging/log4j/catalog/config/JsonObjectMapperFactory.java

Severity Category Rule Message Line
 Error javadoc JavadocPackage Missing package-info.java file.
 Error imports ImportOrder Wrong order for 'org.springframework.http.converter.json.Jackson2ObjectMapperBuilder' import. 38
 Error sizes LineLength Line is longer than 120 characters (found 123). 52
 Error sizes LineLength Line is longer than 120 characters (found 122). 72
 Error coding DeclarationOrder Variable access definition in wrong order. 72

org/apache/logging/log4j/catalog/config/SwaggerConfig.java

Severity Category Rule Message Line
 Error imports ImportOrder 'springfox.documentation.builders.ApiInfoBuilder' should be separated from previous imports. 22
 Error imports ImportControl Disallowed import - springfox.documentation.builders.ApiInfoBuilder. 22
 Error imports ImportControl Disallowed import - springfox.documentation.builders.PathSelectors. 23
 Error imports ImportControl Disallowed import - springfox.documentation.builders.RequestHandlerSelectors. 24
 Error imports ImportControl Disallowed import - springfox.documentation.service.ApiInfo. 25
 Error imports ImportControl Disallowed import - springfox.documentation.spi.DocumentationType. 26
 Error imports ImportControl Disallowed import - springfox.documentation.spring.web.plugins.Docket. 27
 Error imports ImportControl Disallowed import - springfox.documentation.swagger2.annotations.EnableSwagger2. 28
 Error imports ImportOrder Wrong order for 'java.time.LocalDate' import. 30

org/apache/logging/log4j/catalog/config/WebAppInitializer.java

Severity Category Rule Message Line
 Error imports UnusedImports Unused import - org.springframework.context.annotation.Configuration. 24
 Error imports UnusedImports Unused import - org.springframework.web.WebApplicationInitializer. 25
 Error imports UnusedImports Unused import - org.springframework.web.context.ContextLoaderListener. 26
 Error imports UnusedImports Unused import - org.springframework.web.context.support.AnnotationConfigWebApplicationContext. 27
 Error imports UnusedImports Unused import - org.springframework.web.servlet.DispatcherServlet. 28
 Error imports ImportOrder Wrong order for 'javax.servlet.ServletContext' import. 30
 Error imports UnusedImports Unused import - javax.servlet.ServletRegistration. 32
 Error javadoc JavadocType Missing a Javadoc comment. 34
 Error naming StaticVariableName Name 'LOGGER' must match pattern '^[a-z][a-zA-Z0-9]*$'. 36
 Error sizes LineLength Line is longer than 120 characters (found 143). 54

org/apache/logging/log4j/catalog/config/WebMvcAppContext.java

Severity Category Rule Message Line
 Error imports UnusedImports Unused import - java.util.Collections. 22
 Error imports ImportOrder Wrong order for 'org.apache.logging.log4j.LogManager' import. 32
 Error imports UnusedImports Unused import - org.springframework.context.annotation.PropertySource. 56
 Error imports UnusedImports Unused import - org.springframework.context.annotation.Scope. 57
 Error imports UnusedImports Unused import - org.springframework.core.annotation.Order. 59
 Error imports UnusedImports Unused import - org.springframework.scheduling.annotation.EnableScheduling. 62
 Error imports UnusedImports Unused import - org.springframework.web.servlet.ViewResolver. 63
 Error imports UnusedImports Unused import - org.springframework.web.servlet.config.annotation.EnableWebMvc. 65
 Error imports UnusedImports Unused import - org.thymeleaf.spring4.SpringTemplateEngine. 69
 Error imports UnusedImports Unused import - org.thymeleaf.spring4.templateresolver.SpringResourceTemplateResolver. 70
 Error imports UnusedImports Unused import - org.thymeleaf.spring4.view.ThymeleafView. 71
 Error imports UnusedImports Unused import - org.thymeleaf.spring4.view.ThymeleafViewResolver. 72
 Error imports UnusedImports Unused import - org.thymeleaf.templatemode.TemplateMode. 73
 Error javadoc JavadocType Missing a Javadoc comment. 77
 Error design VisibilityModifier Variable 'configurationService' must be private and have accessor methods. 85
 Error coding DeclarationOrder Instance variable definition in wrong order. 155
 Error coding DeclarationOrder Instance variable definition in wrong order. 158
 Error coding DeclarationOrder Instance variable definition in wrong order. 161
 Error coding DeclarationOrder Instance variable definition in wrong order. 164
 Error coding DeclarationOrder Instance variable definition in wrong order. 167
 Error coding DeclarationOrder Instance variable definition in wrong order. 170
 Error coding DeclarationOrder Instance variable definition in wrong order. 173
 Error coding DeclarationOrder Instance variable definition in wrong order. 176
 Error design VisibilityModifier Variable 'sshSessionFactory' must be private and have accessor methods. 190
 Error whitespace ParenPad '(' is followed by whitespace. 192
 Error whitespace ParenPad ')' is preceded with whitespace. 192
 Error whitespace ParenPad '(' is followed by whitespace. 193
 Error whitespace ParenPad ')' is preceded with whitespace. 193
 Error blocks LeftCurly '{' at column 69 should have line break after. 211
 Error whitespace WhitespaceAround 'return' is not preceded with whitespace. 211
 Error whitespace WhitespaceAround '{' is not followed by whitespace. 211
 Error whitespace WhitespaceAfter ';' is not followed by whitespace. 211
 Error whitespace WhitespaceAround '}' is not preceded with whitespace. 211
 Error blocks LeftCurly '{' at column 87 should have line break after. 214
 Error whitespace WhitespaceAround 'return' is not preceded with whitespace. 214
 Error whitespace WhitespaceAround '{' is not followed by whitespace. 214
 Error whitespace WhitespaceAfter ';' is not followed by whitespace. 214
 Error whitespace WhitespaceAround '}' is not preceded with whitespace. 214
 Error blocks LeftCurly '{' at column 89 should have line break after. 217
 Error whitespace WhitespaceAround 'return' is not preceded with whitespace. 217
 Error whitespace WhitespaceAround '{' is not followed by whitespace. 217
 Error whitespace WhitespaceAfter ';' is not followed by whitespace. 217
 Error whitespace WhitespaceAround '}' is not preceded with whitespace. 217
 Error blocks LeftCurly '{' at column 84 should have line break after. 220
 Error whitespace WhitespaceAround 'return' is not preceded with whitespace. 220
 Error whitespace WhitespaceAround '{' is not followed by whitespace. 220
 Error whitespace WhitespaceAfter ';' is not followed by whitespace. 220
 Error whitespace WhitespaceAround '}' is not preceded with whitespace. 220
 Error whitespace WhitespaceAround '{' is not followed by whitespace. 223
 Error whitespace WhitespaceAround '}' is not preceded with whitespace. 223
 Error whitespace WhitespaceAfter 'typecast' is not followed by whitespace. 231
 Error whitespace ParenPad '(' is followed by whitespace. 232
 Error whitespace ParenPad ')' is preceded with whitespace. 232

org/apache/logging/log4j/catalog/controller/AttributeController.java

Severity Category Rule Message Line
 Error imports ImportOrder Wrong order for 'java.lang.reflect.Type' import. 20
 Error javadoc JavadocStyle First sentence should end with a period. 51
 Error sizes LineLength Line is longer than 120 characters (found 132). 78
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 78
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 78
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 78
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 78
 Error sizes LineLength Line is longer than 120 characters (found 128). 79
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 79
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 79
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 79
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 79
 Error sizes LineLength Line is longer than 120 characters (found 127). 80
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 80
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 80
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 80
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 80
 Error whitespace WhitespaceAround '{' is not followed by whitespace. 81
 Error whitespace WhitespaceAround '}' is not preceded with whitespace. 81
 Error sizes LineLength Line is longer than 120 characters (found 135). 101
 Error whitespace WhitespaceAround '{' is not followed by whitespace. 176
 Error whitespace WhitespaceAround '}' is not preceded with whitespace. 176

org/apache/logging/log4j/catalog/controller/CatalogController.java

Severity Category Rule Message Line
 Error imports UnusedImports Unused import - java.text.ParseException. 19
 Error imports UnusedImports Unused import - javax.servlet.http.HttpServletRequest. 23
 Error imports ImportOrder Wrong order for 'org.apache.logging.log4j.catalog.api.Attribute' import. 28
 Error imports UnusedImports Unused import - org.springframework.web.bind.annotation.PathVariable. 47
 Error imports UnusedImports Unused import - org.springframework.web.bind.annotation.RequestMapping. 49
 Error imports UnusedImports Unused import - org.springframework.web.bind.annotation.RequestMethod. 50
 Error imports UnusedImports Unused import - org.springframework.web.bind.annotation.RequestParam. 51
 Error imports ImportOrder Wrong order for 'org.apache.logging.log4j.catalog.api.CatalogData' import. 53
 Error whitespace FileTabCharacter File contains tab characters (this is the first instance). 62

org/apache/logging/log4j/catalog/controller/CategoryController.java

Severity Category Rule Message Line
 Error imports ImportOrder Wrong order for 'java.lang.reflect.Type' import. 20
 Error imports ImportOrder Wrong order for 'org.apache.logging.log4j.catalog.jpa.converter.CategoryConverter' import. 31
 Error javadoc JavadocStyle First sentence should end with a period. 44
 Error sizes LineLength Line is longer than 120 characters (found 131). 71
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 71
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 71
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 71
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 71
 Error sizes LineLength Line is longer than 120 characters (found 127). 72
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 72
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 72
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 72
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 72
 Error sizes LineLength Line is longer than 120 characters (found 126). 73
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 73
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 73
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 73
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 73
 Error whitespace WhitespaceAround '{' is not followed by whitespace. 74
 Error whitespace WhitespaceAround '}' is not preceded with whitespace. 74
 Error sizes LineLength Line is longer than 120 characters (found 134). 94

org/apache/logging/log4j/catalog/controller/ConstraintController.java

Severity Category Rule Message Line
 Error javadoc JavadocStyle First sentence should end with a period. 46
 Error whitespace WhitespaceAround '{' is not followed by whitespace. 62
 Error whitespace WhitespaceAround '}' is not preceded with whitespace. 62

org/apache/logging/log4j/catalog/controller/EventController.java

Severity Category Rule Message Line
 Error imports ImportOrder Wrong order for 'java.lang.reflect.Type' import. 20
 Error imports ImportOrder Wrong order for 'org.apache.logging.log4j.catalog.jpa.converter.EventConverter' import. 32
 Error javadoc JavadocStyle First sentence should end with a period. 45
 Error sizes LineLength Line is longer than 120 characters (found 128). 71
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 71
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 71
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 71
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 71
 Error sizes LineLength Line is longer than 120 characters (found 124). 72
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 72
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 72
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 72
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 72
 Error sizes LineLength Line is longer than 120 characters (found 123). 73
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 73
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 73
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 73
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 73
 Error whitespace WhitespaceAround '{' is not followed by whitespace. 74
 Error whitespace WhitespaceAround '}' is not preceded with whitespace. 74
 Error sizes LineLength Line is longer than 120 characters (found 123). 94

org/apache/logging/log4j/catalog/controller/ProductController.java

Severity Category Rule Message Line
 Error javadoc JavadocPackage Missing package-info.java file.
 Error imports ImportOrder Wrong order for 'org.apache.logging.log4j.catalog.jpa.converter.ProductConverter' import. 26
 Error imports ImportOrder Wrong order for 'java.lang.reflect.Type' import. 39
 Error javadoc JavadocStyle First sentence should end with a period. 45
 Error sizes LineLength Line is longer than 120 characters (found 130). 71
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 71
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 71
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 71
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 71
 Error sizes LineLength Line is longer than 120 characters (found 126). 72
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 72
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 72
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 72
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 72
 Error sizes LineLength Line is longer than 120 characters (found 125). 73
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 73
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 73
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 73
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 73
 Error whitespace WhitespaceAround '{' is not followed by whitespace. 74
 Error whitespace WhitespaceAround '}' is not preceded with whitespace. 74
 Error sizes LineLength Line is longer than 120 characters (found 129). 94

org/apache/logging/log4j/catalog/controller/RestResponseEntityExceptionHandler.java

Severity Category Rule Message Line
 Error javadoc JavadocType Missing a Javadoc comment. 30

org/apache/logging/log4j/catalog/interceptor/RequestContextHeaderInterceptor.java

Severity Category Rule Message Line
 Error javadoc JavadocPackage Missing package-info.java file.
 Error imports UnusedImports Unused import - org.springframework.http.HttpHeaders. 21

org/apache/logging/log4j/catalog/security/LocalAuthorizationInterceptor.java

Severity Category Rule Message Line
 Error javadoc JavadocPackage Missing package-info.java file.
 Error javadoc JavadocType Missing a Javadoc comment. 25
 Error sizes LineLength Line is longer than 120 characters (found 159). 34

org/apache/logging/log4j/catalog/service/CatalogInitializer.java

Severity Category Rule Message Line
 Error javadoc JavadocPackage Missing package-info.java file.
 Error imports ImportOrder Wrong order for 'java.util.ArrayList' import. 20
 Error imports ImportOrder Wrong order for 'org.apache.logging.log4j.catalog.api.Attribute' import. 28
 Error naming ConstantName Name 'logger' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$|^capabilities$|^log$'. 53
 Error design VisibilityModifier Variable 'attributeService' must be private and have accessor methods. 56
 Error design VisibilityModifier Variable 'eventService' must be private and have accessor methods. 59
 Error design VisibilityModifier Variable 'categoryService' must be private and have accessor methods. 62
 Error design VisibilityModifier Variable 'productService' must be private and have accessor methods. 65
 Error design VisibilityModifier Variable 'catalogDao' must be private and have accessor methods. 68
 Error design VisibilityModifier Variable 'attributeConverter' must be private and have accessor methods. 71
 Error design VisibilityModifier Variable 'eventConverter' must be private and have accessor methods. 74
 Error design VisibilityModifier Variable 'categoryConverter' must be private and have accessor methods. 77
 Error design VisibilityModifier Variable 'productConverter' must be private and have accessor methods. 80