Log4j 1.x Adaptor – Checkstyle Results - Apache Log4j 1.x Compatibility API

Checkstyle Results

The following document contains the results of Checkstyle 6.18 with /Users/rgoers/projects/apache/logging/log4j/log4j-2.12.4/log4j-1.2-api/../checkstyle.xml ruleset.

Summary

Files	Info	Warnings	Errors
41	0	0	49

Files

File	I	W	E
org/apache/log4j/AppenderSkeleton.java	0	0	10
org/apache/log4j/Category.java	0	0	4
org/apache/log4j/ConsoleAppender.java	0	0	4
org/apache/log4j/Layout.java	0	0	2
org/apache/log4j/LogManager.java	0	0	1
org/apache/log4j/Priority.java	0	0	3
org/apache/log4j/SimpleLayout.java	0	0	3
org/apache/log4j/config/InputStreamWrapper.java	0	0	2
org/apache/log4j/config/Log4j1ConfigurationConverter.java	0	0	5
org/apache/log4j/config/Log4j1ConfigurationParser.java	0	0	5
org/apache/log4j/layout/Log4j1XmlLayout.java	0	0	3
org/apache/log4j/legacy/core/CategoryUtil.java	0	0	1
org/apache/log4j/pattern/Log4j1MdcPatternConverter.java	0	0	3
org/apache/log4j/pattern/Log4j1NdcPatternConverter.java	0	0	2
org/apache/log4j/spi/Filter.java	0	0	1

Details

org/apache/log4j/AppenderSkeleton.java

Severity	Category	Rule	Message	Line
Error	javadoc	JavadocVariable	Missing a Javadoc comment.	29
Error	javadoc	JavadocVariable	Missing a Javadoc comment.	31
Error	javadoc	JavadocVariable	Missing a Javadoc comment.	33
Error	javadoc	JavadocVariable	Missing a Javadoc comment.	35
Error	javadoc	JavadocVariable	Missing a Javadoc comment.	37
Error	javadoc	JavadocVariable	Missing a Javadoc comment.	39
Error	javadoc	JavadocVariable	Missing a Javadoc comment.	41
Error	whitespace	WhitespaceAround	'if' is not followed by whitespace.	60
Error	coding	SuperFinalize	Method 'finalize' should call 'super.finalize'.	76
Error	javadoc	JavadocType	Missing a Javadoc comment.	145

org/apache/log4j/Category.java

Severity	Category	Rule	Message	Line
Error	imports	ImportOrder	Wrong order for 'org.apache.logging.log4j.message.LocalizedMessage' import.	32
Error	naming	ConstantName	Name 'isCoreAvailable' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$\|^capabilities$\|^log$'.	51
Error	coding	HiddenField	'bundle' hides a field.	401
Error	javadoc	JavadocType	Missing a Javadoc comment.	502

org/apache/log4j/ConsoleAppender.java

Severity	Category	Rule	Message	Line
Error	blocks	LeftCurly	'{' at column 1 should be on the previous line.	25
Error	blocks	LeftCurly	'{' at column 3 should be on the previous line.	32
Error	blocks	LeftCurly	'{' at column 3 should be on the previous line.	40
Error	blocks	LeftCurly	'{' at column 3 should be on the previous line.	49

org/apache/log4j/Layout.java

Severity	Category	Rule	Message	Line
Error	javadoc	JavadocVariable	Missing a Javadoc comment.	27
Error	modifier	ModifierOrder	'static' modifier out of order with the JLS suggestions.	27

org/apache/log4j/LogManager.java

Severity	Category	Rule	Message	Line
Error	naming	ConstantName	Name 'isLog4jCore' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$\|^capabilities$\|^log$'.	67

org/apache/log4j/Priority.java

Severity	Category	Rule	Message	Line
Error	design	VisibilityModifier	Variable 'level' must be private and have accessor methods.	96
Error	design	VisibilityModifier	Variable 'levelStr' must be private and have accessor methods.	97
Error	design	VisibilityModifier	Variable 'syslogEquivalent' must be private and have accessor methods.	98

org/apache/log4j/SimpleLayout.java

Severity	Category	Rule	Message	Line
Error	blocks	LeftCurly	'{' at column 1 should be on the previous line.	26
Error	blocks	LeftCurly	'{' at column 3 should be on the previous line.	33
Error	blocks	LeftCurly	'{' at column 3 should be on the previous line.	42

org/apache/log4j/config/InputStreamWrapper.java

Severity	Category	Rule	Message	Line
Error	javadoc	JavadocType	Missing a Javadoc comment.	22
Error	modifier	RedundantModifier	Redundant 'public' modifier.	27

org/apache/log4j/config/Log4j1ConfigurationConverter.java

Severity	Category	Rule	Message	Line
Error	sizes	LineLength	Line is longer than 120 characters (found 126).	50
Error	javadoc	JavadocType	Missing a Javadoc comment.	55
Error	coding	DeclarationOrder	Instance variable definition in wrong order.	141
Error	coding	DeclarationOrder	Constructor definition in wrong order.	143
Error	sizes	LineLength	Line is longer than 120 characters (found 127).	179

org/apache/log4j/config/Log4j1ConfigurationParser.java

Severity	Category	Rule	Message	Line
Error	sizes	LineLength	Line is longer than 120 characters (found 139).	56
Error	sizes	LineLength	Line is longer than 120 characters (found 139).	57
Error	sizes	LineLength	Line is longer than 120 characters (found 133).	58
Error	sizes	LineLength	Line is longer than 120 characters (found 140).	59
Error	sizes	LineLength	Line is longer than 120 characters (found 124).	60

org/apache/log4j/layout/Log4j1XmlLayout.java

Severity	Category	Rule	Message	Line
Error	javadoc	JavadocPackage	Missing package-info.java file.
Error	coding	DeclarationOrder	Constructor definition in wrong order.	58
Error	whitespace	FileTabCharacter	File contains tab characters (this is the first instance).	112

org/apache/log4j/legacy/core/CategoryUtil.java

Severity	Category	Rule	Message	Line
Error	javadoc	JavadocPackage	Missing package-info.java file.

org/apache/log4j/pattern/Log4j1MdcPatternConverter.java

Severity	Category	Rule	Message	Line
Error	sizes	LineLength	Line is longer than 120 characters (found 126).	82
Error	coding	DeclarationOrder	Static variable definition in wrong order.	82
Error	naming	StaticVariableName	Name 'APPEND_EACH' must match pattern '^[a-z][a-zA-Z0-9]*$'.	82

org/apache/log4j/pattern/Log4j1NdcPatternConverter.java

Severity	Category	Rule	Message	Line
Error	javadoc	JavadocPackage	Missing package-info.java file.
Error	imports	ImportOrder	Wrong order for 'java.util.List' import.	26

org/apache/log4j/spi/Filter.java

Severity	Category	Rule	Message	Line
Error	design	VisibilityModifier	Variable 'next' must be private and have accessor methods.	48