Log4j Web Support – Checkstyle Results - Apache Log4j Web

Checkstyle Results

The following document contains the results of Checkstyle 6.1.1 with /Users/rgoers/projects/apache/logging/log4j/log4j-2.3.x/log4j-web/../checkstyle.xml ruleset.

Summary

Files	Info	Warnings	Errors
11	0	0	27

Files

File	I	W	E
log4j2.component.properties	0	0	1
org/apache/logging/log4j/web/Log4jServletContainerInitializer.java	0	0	5
org/apache/logging/log4j/web/Log4jServletContextListener.java	0	0	3
org/apache/logging/log4j/web/Log4jServletFilter.java	0	0	8
org/apache/logging/log4j/web/Log4jWebInitializerImpl.java	0	0	2
org/apache/logging/log4j/web/WebLoggerContextUtils.java	0	0	2
org/apache/logging/log4j/web/WebLookup.java	0	0	2
org/apache/logging/log4j/web/appender/ServletAppender.java	0	0	4

Details

log4j2.component.properties

Severity	Category	Rule	Message	Line
Error	misc	NewlineAtEndOfFile	File does not end with a newline.

org/apache/logging/log4j/web/Log4jServletContainerInitializer.java

Severity	Category	Rule	Message	Line
Error	imports	ImportControl	Disallowed import - javax.servlet.DispatcherType.	21
Error	imports	ImportControl	Disallowed import - javax.servlet.FilterRegistration.	22
Error	imports	ImportControl	Disallowed import - javax.servlet.ServletContainerInitializer.	23
Error	imports	ImportControl	Disallowed import - javax.servlet.ServletContext.	24
Error	imports	ImportControl	Disallowed import - javax.servlet.ServletException.	25

org/apache/logging/log4j/web/Log4jServletContextListener.java

Severity	Category	Rule	Message	Line
Error	imports	ImportControl	Disallowed import - javax.servlet.ServletContext.	19
Error	imports	ImportControl	Disallowed import - javax.servlet.ServletContextEvent.	20
Error	imports	ImportControl	Disallowed import - javax.servlet.ServletContextListener.	21

org/apache/logging/log4j/web/Log4jServletFilter.java

Severity	Category	Rule	Message	Line
Error	imports	ImportControl	Disallowed import - javax.servlet.Filter.	20
Error	imports	ImportControl	Disallowed import - javax.servlet.FilterChain.	21
Error	imports	ImportControl	Disallowed import - javax.servlet.FilterConfig.	22
Error	imports	ImportControl	Disallowed import - javax.servlet.ServletContext.	23
Error	imports	ImportControl	Disallowed import - javax.servlet.ServletException.	24
Error	imports	ImportControl	Disallowed import - javax.servlet.ServletRequest.	25
Error	imports	ImportControl	Disallowed import - javax.servlet.ServletResponse.	26
Error	coding	DeclarationOrder	Variable access definition in wrong order.	46

org/apache/logging/log4j/web/Log4jWebInitializerImpl.java

Severity	Category	Rule	Message	Line
Error	imports	ImportControl	Disallowed import - javax.servlet.ServletContext.	23
Error	sizes	LineLength	Line is longer than 120 characters (found 123).	165

org/apache/logging/log4j/web/WebLoggerContextUtils.java

Severity	Category	Rule	Message	Line
Error	imports	ImportControl	Disallowed import - javax.servlet.ServletContext.	21
Error	coding	DeclarationOrder	Static variable definition in wrong order.	39

org/apache/logging/log4j/web/WebLookup.java

Severity	Category	Rule	Message	Line
Error	imports	ImportControl	Disallowed import - javax.servlet.ServletContext.	21
Error	javadoc	JavadocType	Missing a Javadoc comment.	28

org/apache/logging/log4j/web/appender/ServletAppender.java

Severity	Category	Rule	Message	Line
Error	javadoc	JavadocPackage	Missing package-info.java file.
Error	imports	ImportControl	Disallowed import - javax.servlet.ServletContext.	20
Error	javadoc	JavadocStyle	First sentence should end with a period.	35
Error	design	FinalClass	Class ServletAppender should be declared as final.	38